Refactor networking (do not merge) #2104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a config type for accessing data Add bridgeiface name to config Add option to disable iptables
- Example: `EXPOSE 8080-8089` opens ports 8080 to 8089 (inclusive) - Valid port ranges should be in form [0-9]+-[0-9]+ - buildfile_test.go tests edge values as well as an 'implied' inner value - Note: Ports are not confirmed to within 1 and 65535 when parsed. - Note: Ports are not checked for uniqueness when parsed.
|
@idetik if you're not ready for us to review, could you close the pull request and re-open it when you're ready? Makes the bookkeeping easier for us. Thanks. |
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in resolution of this issue:
#1834
I cannot find the refactor-networking branch anymore.
Am I making the pull request to the wrong branch?
--Robert