Tar up contents of child directory onto tmpfs if mounted over #13212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that this pull request is causing issues similar to the following when creating containers from images which do not have a /tmp directory (like an image created using |
|
@lheinlen-os Is that on a Fedora or RHEL system? This patch would not cause that but using the patch for mounting a tmpfs on /tmp might. |
|
@lheinlen-os I added a check to make sure fullDest exists before running the tar commands which should prevent the failure you are seeing |
|
@rhatdan Excellent! Thank you! |
|
I am reworking these patches to only happen when you run in systemd mode. BTW. |
|
#13525 |
This patch will use the new PreMount and PostMount hooks to "tar" up the contents of the base image on top of tmpfs mount points. We want to add support for /run and /tmp on tmpfs and Michael Chrosby idea to add --tmpfs PATH would require a patch like this. Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)
This patch will allow users to setup tmpfs mounts on top of any directory. One of the big benefits of this would be to allow --read-only to work when an application needs to write to /run or /tmp. Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)
|
I have incorporated this pull request into #13587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will use the new PreMount and PostMount hooks to "tar"
up the contents of the base image on top of tmpfs mount points.
We want to add support for /run and /tmp on tmpfs and Michael Chrosby idea to
add --tmpfs PATH would require a patch like this.
Docker-DCO-1.1-Signed-off-by: Dan Walsh dwalsh@redhat.com (github: rhatdan)