Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL updates #12814

Merged
merged 3 commits into from Apr 28, 2015
Merged

RHEL updates #12814

merged 3 commits into from Apr 28, 2015

Conversation

vbatts
Copy link
Contributor

@vbatts vbatts commented Apr 27, 2015

  • update version 6.5 -> 6.6
  • bump kernel version

Closes #9856

/cc @LK4D4 @unclejack @thaJeztah @tiborvass

@tiborvass
Copy link
Contributor

LGTM

@thaJeztah
Copy link
Member

LGTM, thanks! Perhaps you can add a comment on the linked issue to inform people arriving there that the (kernel) requirements have changed. (For those arriving there through Google)

@vbatts
Copy link
Contributor Author

vbatts commented Apr 27, 2015

@thaJeztah I thought about that, though wasn't sure if we wanted the docs to continue growing with links to issues...

@vbatts
Copy link
Contributor Author

vbatts commented Apr 27, 2015

@thaJeztah added

@thaJeztah
Copy link
Member

@vbatts oh sorry if I wasn't clear, I meant just a comment on #9856 here on the issue tracker. Some people are lazy and just start commenting on an issue without reading all comments, so a "final" comment hopefully prevents that.

@vbatts
Copy link
Contributor Author

vbatts commented Apr 27, 2015

oh right. I thought the inverse, but for the same reason. If I just left a
comment on the issue, then folks may continue commenting on the closed
issue and miss the "final" resolution. But if the link is in the docs, that
is really, very final.

This happens a lot with devicemapper issues. We make the "final" comment,
but folks just ignore the fix/solution and continue to comment, then it's
lost. :-\

Should I remove this link from the docs?

On Mon, Apr 27, 2015 at 2:47 PM, Sebastiaan van Stijn <
notifications@github.com> wrote:

@vbatts https://github.com/vbatts oh sorry if I wasn't clear, I meant
just a comment on #9856 #9856
here on the issue tracker. Some people are lazy and just start commenting
on an issue without reading all comments, so a "final" comment hopefully
prevents that.


Reply to this email directly or view it on GitHub
#12814 (comment).

@thaJeztah
Copy link
Member

Should I remove this link from the docs?

Hm, not sure it adds much to the docs, but just leave it for now until @moxiegirl has had a look, she might have a more firm preference either way (and the commits also have to be squashed, so you're not done yet 😇)

@@ -7,7 +7,7 @@ page_keywords: Docker, Docker documentation, requirements, linux, rhel
Docker is supported on the following versions of RHEL:

- [*Red Hat Enterprise Linux 7 (64-bit)*](#red-hat-enterprise-linux-7-installation)
- [*Red Hat Enterprise Linux 6.5 (64-bit)*](#red-hat-enterprise-linux-6.5-installation) or later
- [*Red Hat Enterprise Linux 6.6 (64-bit)*](#red-hat-enterprise-linux-6.6-installation) or later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work as written. You need to change 6.6 to 66

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Well spotted!

@moxiegirl
Copy link
Contributor

I believe officially we only require the 3.10 kernel or higher which is what 7 is running. I've been told by the team we only support kernel 2.6.32 on RedHat so for 6.6 you have that covered.

Just that link fix should do it.

@thaJeztah
Copy link
Member

I believe officially we only require the 3.10 kernel or higher which is what 7 is running. I've been told by the team we only support kernel 2.6.32 on RedHat so for 6.6 you have that covered.

Correct, IIRC the minimum kernel is 3.13. The RedHat / CentOS distros are an exception to this because (as mentioned) they back-port changes that are needed for Docker to work; Kernel 2.6.x on other distros is not supported because those lack those changes.

@SvenDowideit
Copy link
Contributor

LGTM, once @vbatts fixes the link - easy way to test is to run make docs in your branch.

Signed-off-by: Vincent Batts <vbatts@redhat.com>
Closes moby#9856

Signed-off-by: Vincent Batts <vbatts@redhat.com>
Signed-off-by: Vincent Batts <vbatts@redhat.com>
@vbatts
Copy link
Contributor Author

vbatts commented Apr 28, 2015

fixed the link

@moxiegirl
Copy link
Contributor

@SvenDowideit Thanks, I know that. That's how I found the break.

@moxiegirl
Copy link
Contributor

@vbatts everything LGTM. Thank you for the contribution.

moxiegirl pushed a commit that referenced this pull request Apr 28, 2015
@moxiegirl moxiegirl merged commit 6113eab into moby:master Apr 28, 2015
@thaJeztah thaJeztah mentioned this pull request May 2, 2015
@vbatts vbatts deleted the vbatts-rhel_updates branch April 27, 2016 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel Panic when mounting volumes on RHEL 6.5 using Docker 1.4.0, Docker 1.4.1, with latest device mapper
6 participants