[WiP] Adds testing for bridge's IPv6 support #11459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes moby#10001 * test for global subnets <= 80 * test for global subnets > 80 * test link local allocations * test duplicated addresses * test regression from bug moby#11427 Signed-off-by: Christian Simon <simon@swine.de>
|
Nice! These look like some great additions-- @MalteJ do you have time to review/provide feedback? |
|
That's cool. Probably it's time to write integration-cli tests as well. |
|
LGTM |
1 similar comment
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Mar 19, 2015
[WiP] Adds testing for bridge's IPv6 support
|
great! Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here my first try to add some tests for the IPv6 bridge implementation (cf. #10001). Comments and help are warmly appreciated, since this is my first Docker / Golang contribution.
I implemented the following tests:
Cheers