Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumes-from comma separated list #7580

Closed
mbn18 opened this issue Aug 14, 2014 · 12 comments
Closed

volumes-from comma separated list #7580

mbn18 opened this issue Aug 14, 2014 · 12 comments

Comments

@mbn18
Copy link

mbn18 commented Aug 14, 2014

The doc state:

Containers can be specified by a comma separated list or by repetitions of the --volumes-from argument.

This does not work for me:

--volumes-from vol1, vol2, voln

I also tried other variation like with/without space and etc

@mbn18
Copy link
Author

mbn18 commented Aug 14, 2014

Its a stable CoreOS

'''
Linux canfigureit 3.15.2+ #2 SMP Sat Jul 12 23:12:25 UTC 2014 x86_64 Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz GenuineIntel GNU/Linux

Client version: 1.0.1
Client API version: 1.12
Go version (client): go1.2
Git commit (client): 990021a
Server version: 1.0.1
Server API version: 1.12
Go version (server): go1.2
Git commit (server): 990021a
'''

@cpuguy83
Copy link
Member

@mbn18 What docs?

@mbn18
Copy link
Author

mbn18 commented Aug 14, 2014

@cpuguy83
Copy link
Member

@mbn18 Yep, looks like some bad docs.
Care to make a PR?

@mbn18
Copy link
Author

mbn18 commented Aug 15, 2014

@cpuguy83 PR to what? fixing the docs? add support for comm separated list?

@cpuguy83
Copy link
Member

Fix the docs

@mbn18
Copy link
Author

mbn18 commented Aug 17, 2014

@cpuguy83, Will do that

@xiaods
Copy link
Contributor

xiaods commented Aug 20, 2014

From my test, Options with [] may be specified multiple times. it does mean docker can support comma separated list.
Example:
case 1, works:
docker run -it --rm --volumes-from TEST_DATA --volumes-from TEST_DATA2 ubuntu bash

case 2, failed:
docker run -it --rm --volumes-from TEST_DATA,TEST_DATA2 ubuntu bash
2014/08/20 15:40:35 Error response from daemon: Cannot start container e2f63ce5611c7a1be28389580d4a3847713078e6d5b61aac6cd532ec68b02191: Container TEST_DATA,TEST_DATA2 not found. Impossible to mount its volumes

@mbn18
Copy link
Author

mbn18 commented Aug 20, 2014

@xiaods I also tried ["volume1", "volume2"]
That faild

@xiaods
Copy link
Contributor

xiaods commented Aug 20, 2014

@mbn18 you misunderstand the doc, current support this style:
docker run -it --rm --volumes-from TEST_DATA --volumes-from TEST_DATA2 ubuntu bash

@xiaods
Copy link
Contributor

xiaods commented Aug 20, 2014

@mbn18 Options like -a=[] indicate they can be specified multiple times:
$ docker run -a stdin -a stdout -a stderr -i -t ubuntu /bin/bash

xiaods pushed a commit to xiaods/docker that referenced this issue Aug 20, 2014
issue moby#7580 volumes-from comma separated list mentioned this case.

Options like --volumes-from=[] indicate they can be specified multiple times:
docker run -it --rm --volumes-from TEST_DATA --volumes-from TEST_DATA2 ubuntu bash

Signed-off-by: Deshi Xiao <dxiao@redhat.com>
@cpuguy83
Copy link
Member

Closing since this was resolved.

Thanks @xiaods @mbn18

SvenDowideit pushed a commit to SvenDowideit/docker that referenced this issue Aug 27, 2014
issue moby#7580 volumes-from comma separated list mentioned this case.

Options like --volumes-from=[] indicate they can be specified multiple times:
docker run -it --rm --volumes-from TEST_DATA --volumes-from TEST_DATA2 ubuntu bash

Signed-off-by: Deshi Xiao <dxiao@redhat.com>
(cherry picked from commit 4d0b88c)

Conflicts:
	docs/sources/reference/commandline/cli.md

Docker-DCO-1.1-Signed-off-by: Deshi Xiao <dxiao@redhat.com> (github: SvenDowideit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants