Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests required for IPv6 #10001

Closed
MalteJ opened this issue Jan 9, 2015 · 7 comments
Closed

Tests required for IPv6 #10001

MalteJ opened this issue Jan 9, 2015 · 7 comments

Comments

@MalteJ
Copy link
Contributor

MalteJ commented Jan 9, 2015

We need some tests to ensure the IPv6 implementation is working as expected.

@emsi
Copy link

emsi commented Jan 12, 2015

Please provide some instructions. I built 1.4.1-dev but it says flag provided but not defined: --ipv6.

@MalteJ
Copy link
Contributor Author

MalteJ commented Jan 12, 2015

@emsi you may download the compiled binary here: https://master.dockerproject.com/
and then put it to /usr/bin/docker

For compiling instructions have a look at https://docs.docker.com/contributing/devenvironment/

@emsi
Copy link

emsi commented Jan 12, 2015

That's exactly what I did. I followed the the build instructions and it produced docker-1.4.1-devel:

root@emsi-docker:~/git/docker# docker version
Client version: 1.4.1-dev
Client API version: 1.16
Go version (client): go1.4
Git commit (client): de97839
OS/Arch (client): linux/amd64
Server version: 1.4.1-dev
Server API version: 1.16
Go version (server): go1.4
Git commit (server): de97839

which says:

flag provided but not defined: --ipv6

The source seems right:

root@emsi-docker:~/git/docker# grep EnableIPv6 daemon/config.go 
        EnableIPv6                  bool
        flag.BoolVar(&config.EnableIPv6, []string{"-ipv6"}, false, "Enable IPv6 networking")

Should I enable is somehow at build time?

p.s. I already enabled IPv6 manually: #5811 (comment)

@MalteJ
Copy link
Contributor Author

MalteJ commented Jan 12, 2015

@emsi You have to start Docker as a Daemon: docker -d --ipv6 --fixed-cidr-v6=2001:db8::/64

BTW: You are off-topic in this issue ;)
This issue is about creating unit tests for the IPv6 source code.
Feel free to create a new Issue with your specific problem and ping me by mentioning @MalteJ :-)

@Tr4pSt3R
Copy link

@emsi and @MalteJ do you need help or support with this testing? I can help or collaborate with you guys on?

@MalteJ
Copy link
Contributor Author

MalteJ commented Jan 15, 2015

@Tr4pSt3R yeah, would be nice if I'd get some help creating the unit and integration tests. My time is a bit limited at the moment.

@Tr4pSt3R
Copy link

👍 @simonswine LGTM (but have to admit, I haven't run it though.)

wlan0 pushed a commit to wlan0/docker that referenced this issue Apr 2, 2015
* fixes moby#10001
* test for global subnets <= 80
* test for global subnets > 80
* test link local allocations
* test duplicated addresses
* test regression from bug moby#11427

Signed-off-by: Christian Simon <simon@swine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants