Skip to content

Commit

Permalink
Add more error details on plugin get
Browse files Browse the repository at this point in the history
Seeing this `ErrNotImplements` in some of our logs and it's not very
helpful because we don't know what plugin is causing it or even what the
requested interface is.

```
{"message":"legacy plugin: Plugin does not implement the requested driver"}
```

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
  • Loading branch information
cpuguy83 committed Jul 15, 2020
1 parent 60c45c3 commit b1a3fe4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/plugins/plugins.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ package plugins // import "github.com/docker/docker/pkg/plugins"

import (
"errors"
"fmt"
"sync"
"time"

Expand Down Expand Up @@ -265,7 +266,7 @@ func Get(name, imp string) (*Plugin, error) {
logrus.Debugf("%s implements: %s", name, imp)
return pl, nil
}
return nil, ErrNotImplements
return nil, fmt.Errorf("%w: plugin=%q, requested implementation=%q", ErrNotImplements, name, imp)
}

// Handle adds the specified function to the extpointHandlers.
Expand Down

0 comments on commit b1a3fe4

Please sign in to comment.