Merge pull request #43426 from thaJeztah/20.10_backport_info_counters…

…_rwmutex [20.10 backport] daemon: use RWMutex for stateCounter
moby · Mar 25, 2022 · 4e188b8 · 4e188b8
2 parents 339d7bd + 32fe0bb
commit 4e188b8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/daemon/metrics.go b/daemon/metrics.go
@@ -65,7 +65,7 @@ func init() {
 }
 
 type stateCounter struct {
-	mu     sync.Mutex
+	mu     sync.RWMutex
 	states map[string]string
 	desc   *prometheus.Desc
 }
@@ -78,8 +78,8 @@ func newStateCounter(desc *prometheus.Desc) *stateCounter {
 }
 
 func (ctr *stateCounter) get() (running int, paused int, stopped int) {
-	ctr.mu.Lock()
-	defer ctr.mu.Unlock()
+	ctr.mu.RLock()
+	defer ctr.mu.RUnlock()
 
 	states := map[string]int{
 		"running": 0,