Only check if route overlaps routes with scope: LINK #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Svensson <mikael.svensson@nasdaq.com>
Nossnevs
force-pushed
the
backport-linux-routeoverlaps-link-only-moby-42598
branch
from
25a71ea
to
9db86fb
Compare
|
The failing test does not seam to be related to this PR. |
|
@thaJeztah i see that other PR have some problems also with the CI. Do you think we can get this PR in without change the CI pipeline? |
|
I kicked CI again, and it's green now, so looks like just a flaky test 👍 |
thaJeztah
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
LGTM, thanks!
compared the diff with moby/moby#42598, and they're identical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikael Svensson mikael.svensson@nasdaq.com
PR for completing moby/moby#43360 to backbort fix from moby/moby#42598 to moby 20.10
Update to moby/moby#43360 will happen when this is merged.