Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gotest.tools dependency #29

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 12, 2023

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@dims
Copy link
Collaborator

dims commented Jan 12, 2023

I prefer this as we completely eliminate 2 packages (as opposed to the PR #28)

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

I prefer this as we completely eliminate 2 packages (as opposed to the PR #28)

Yup, same.

Also eyeing logrus, but it appears to be used in quite a few places, so perhaps that's for a later concern.

I do want to have a quick look at;

  • updating GitHub actions to test against current versions (we can keep 1.13 as "oldest" version in the matrix; probably no harm
  • update golangci-lint (probably needed if we update go versions)
  • update the golang.org/x/sys to a tagged release, and update logrus to get old versions out of the dependency tree

@thaJeztah
Copy link
Member Author

@cpuguy83 PTAL 🤗

@pacoxu
Copy link

pacoxu commented Jan 13, 2023

Great work.

@justincormack justincormack merged commit d2a9113 into moby:master Jan 13, 2023
@thaJeztah thaJeztah deleted the remove_gotest_tools branch January 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants