contenthash: make all paths strings when converting #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using []byte for paths is just begging for a mistake to be made, so
update the signature of convert{PathToKey,KeyToPath} so that only keys
are []byte and paths are always strings.
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
contenthash-cleanup-keypath-helpers
branch
from
e583697
to
c9dac11
Compare
|
Converted with |
jedevc
approved these changes
May 7, 2024
|
Cheers @cyphar, much appreciated 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a smaller patch split off from #4896 which should be trivial to review and allow me to get CI runs without needing approval each time I push a fixed version.)
Using []byte for paths is just begging for a mistake to be made, so update the signature of convert{PathToKey,KeyToPath} so that only keys are []byte and paths are always strings.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com