remotecache: allow exporting root cache records #4803
Draft
+334
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Allow exporting layers of root sources, like base images to remote cache. Normally, this is not done as it is considered wasteful as pulling cache vs. pulling source image again does not have benefits. Skipping base images in cache has other side effects though, for example provenance of a cached build that is on top of previous base image does not list the layers for the LLB image step because that step did not run (because its children were fully cached) and the image step itself does not have a layer chain associated with it in the cache. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
reviewed
Mar 28, 2024
| @@ -36,6 +36,7 @@ type Exporter interface { | |||
|
|
|||
| type Config struct { | |||
| Compression compression.Config | |||
| WithRoots bool | |||
There was a problem hiding this comment.
Could you add a godoc comment to explain the "roots"?
jedevc
reviewed
Mar 28, 2024
| @@ -75,13 +78,24 @@ func getConfig(attrs map[string]string) (*Config, error) { | |||
| return nil, errors.Wrap(err, "failed to parse timeout for github actions cache") | |||
| } | |||
| } | |||
|
|
|||
| rootfs := false | |||
There was a problem hiding this comment.
Suggested change
| rootfs := false | |
| roots := false |
Not sure I understand. Are you asking if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow exporting layers of root sources, like base images to
remote cache. Normally, this is not done as it is considered
wasteful as pulling cache vs. pulling source image again
does not have benefits.
Skipping base images in cache has other side effects though,
for example provenance of a cached build that is on top of
previous base image does not list the layers for the
LLB image step because that step did not run (because its
children were fully cached) and the image step itself
does not have a layer chain associated with it in the cache.
Local source exports roots by default to allow air-gapped builds
with local cache sources if they only match the base image and
no records on top of them. A future follow-up could be to consider
exporting roots by default all the time but marking them in a
special way so they can be skipped from loading.