Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update run --mount verbiage #3406

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Dec 14, 2022

Signed-off-by: David Karlsson david.karlsson@docker.com

Signed-off-by: David Karlsson <david.karlsson@docker.com>
@dvdksn dvdksn force-pushed the docs/dockerfile-run-mount-verbiage branch from 7bfe378 to 9490fd1 Compare December 14, 2022 13:24
@jedevc jedevc merged commit bd9225c into moby:master Dec 14, 2022
`RUN --mount` allows you to create filesystem mounts that the build can access.
This can be used to:

- Create bind mount to the host filesystem or other build stages
Copy link
Member

@thaJeztah thaJeztah Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

host filesystem may be confusing here; as far as I know, we don't support --mount type=bind,source=/some/arbitrary/path/on/host.

The above case has lead to long debates (as we want to keep the build environment isolated, and not able to modify state on the host), see moby/moby#14080, so from that perspective we should avoid confusion if possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should probably outline that it mounts from a) the host where the builder / daemon runs, and b) that (for bind-mounts), it mounts from the build-context storage that's used by the builder (which holds am immutable copy of files used during build). The BuildKit maintainers are probable better suited to fill in the blanks for me 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants