Bump urfave/cli to 2.23.5 #3330
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
|
Ah, yes, this may be a tricky one; ISTR that v2 adhered more strictly to POSIX, but in doing so have removed features that we may depend on (runc was in the same situation), or that users may expect (the "flags before args" is something that both Cobra and urfave accepted, and some users started to depend on this) - admitted perhaps less of an issue for |
|
Yes mostly wanted to update to see if it removes unrelated dependencies on this package but looks like it brings another one that we don't need https://github.com/urfave/cli/blob/1510efe770578f90c236d08a4cfd324106106812/go.mod#L7. And there is still man and markdown related dependencies that bothers me and the diff is not that great now 😟. |
|
Yeah, and as both runc and containerd are on v1, probably better to stick with it for now. There's a build tag though to disable man-page generating, which also makes the binaries smaller. |
https://cli.urfave.org/migrate-v1-to-v2/
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com