-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: use tools build constraint for generated-files deps #3236
Conversation
f2c9958
to
47bd4b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me - I have some confusion around pb_tools.go
, but otherwise looks good to me.
Nice to see the collection of shell scripts shrinking and moving into Dockerfiles.
47bd4b3
to
956bfce
Compare
956bfce
to
27c2d39
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
27c2d39
to
abe457d
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
abe457d
to
e1b3b6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need for tools.go
is still kind of frustrating, but it feels a bit like a necessary evil - it's still an improvement on what we have today, so seems fine to me 🤷
PTAL @tonistiigi
As discussed with tonis, I have updated the comment in the package to warn users if they want to add other tools. |
fixes #3187
follow-up docker/buildx#1296 (comment)
Inferred
go install
fromgo.mod
using tools build constraint so proto generation is aligned.github.com/golang/protobuf/protoc-gen-go
switches from1.3.5
to1.5.2
.Looking at the release notes and since 1.4.0:
The API of this new module is not drop-in compatible with the earlier
github.com/golang/protobuf
module. See https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.20.0 for backward compat.