Fix cross-repo push fallback when access to the source repo is not granted #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b7a5fc. This patch casues issues for cross-repo mounts when user doesn't have credentials for source repo and fallback needs to happen. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
When server does not return expiration time for token default to 60s. This replaces previous solution in error handling that broke cross-repo push. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2454
Reverts #2062 and replace with a default expiration time for the case where expiration time is not sent by the server.
@jmacelroy @dchw