contenthash: include basename in content checksum for wildcards #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
wildcard-copy
branch
from
8827e29
to
a776df1
Compare
|
needs rebase |
|
@tonistiigi should we cherry-pick this one for v0.8.x ? |
While we generally ignore the basename in this layer, for wildcards there in no other place to add the basename to the checksum as they can not be resolved earlier. Before the basename that was in the checksum was the wildcard itself, so if the wildcard remained same, content remained same but the file where wildcard pointed to was renamed, the cache was not invalidated. Unfortunately, this change breaks cache for all copy commands that use a wildcard. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
wildcard-copy
branch
from
a776df1
to
1982e1e
Compare
|
@AkihiroSuda @tiborvass @hinshun I see this was rebased; ptal |
AkihiroSuda
approved these changes
Apr 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2008
While we generally ignore the basename in this layer, for wildcards
there in no other place to add the basename to the checksum as they
can not be resolved earlier. Before the basename that was in the
checksum was the wildcard itself, so if the wildcard remained same,
content remained same but the file where wildcard pointed to was
renamed, the cache was not invalidated.
Unfortunately, this change breaks cache for all copy commands that
use a wildcard.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com