Remove potentially expired tokens #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchw
force-pushed
the
corey/fix-stale-tokens
branch
2 times, most recently
from
d6eb26a
to
35c5e37
Compare
dchw
commented
Apr 2, 2021
tonistiigi
reviewed
Apr 6, 2021
dchw
force-pushed
the
corey/fix-stale-tokens
branch
from
14ab89d
to
92d21ff
Compare
tonistiigi
reviewed
Apr 12, 2021
|
@dchw Please squash commits. lgtm otherwise |
|
Sorry! Things have been a bit crazy for me lately. |
Some registries (notably Quay) issue tokens that expire without providing an `expires in` value in the authorization payload. Therefore, if a token produces a 401, we should remove it and re-fetch. Signed-off-by: Corey Larson <corey@earthly.dev>
dchw
force-pushed
the
corey/fix-stale-tokens
branch
from
b8fcd1e
to
9b7a5fc
Compare
tonistiigi
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some registries (notably Quay) issue tokens that expire without providing an
expires invalue in the authorization payload. Therefore, if a token produces a 401, we should remove it and re-fetch.I admit this is a hack... likely incomplete and/or the wrong way to approach it. Any guidance would be great. The point is that we need to avoid using tokens that may have expired.
This (or a better approach) should resolve #2055 (and also thereby resolve earthly/earthly#890, too)