Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3582, AbortSignal leaks @types/node #3583

Merged
merged 7 commits into from
Jan 14, 2023
Merged

Fix #3582, AbortSignal leaks @types/node #3583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1fb861
fix
urugator Nov 22, 2022
d8f610d
remove superfluous "See"
urugator Nov 22, 2022
e1e1809
Merge remote-tracking branch 'upstream/main' into fix-3582
urugator Nov 24, 2022
68cf207
Merge remote-tracking branch 'upstream/main' into fix-3582
urugator Jan 7, 2023
4f47d5d
Merge remote-tracking branch 'upstream/main' into fix-3582
urugator Jan 7, 2023
8044cbd
remove export
urugator Jan 7, 2023
7161187
Merge remote-tracking branch 'upstream/main' into fix-3582
urugator Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-kiwis-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"mobx": patch
---

fix #3582: AbortSignal leaks @types/node
14 changes: 11 additions & 3 deletions packages/mobx/src/api/when.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@ import {
allowStateChanges
} from "../internal"

// https://github.com/mobxjs/mobx/issues/3582
interface GenericAbortSignal {
readonly aborted: boolean
onabort?: ((...args: any) => any) | null
addEventListener?: (...args: any) => any
removeEventListener?: (...args: any) => any
}

export interface IWhenOptions {
name?: string
timeout?: number
onError?: (error: any) => void
signal?: AbortSignal
signal?: GenericAbortSignal
}

export function when(
Expand Down Expand Up @@ -90,8 +98,8 @@ function whenPromise(
disposer()
reject(new Error("WHEN_ABORTED"))
}
opts?.signal?.addEventListener("abort", abort)
}).finally(() => opts?.signal?.removeEventListener("abort", abort))
opts?.signal?.addEventListener?.("abort", abort)
}).finally(() => opts?.signal?.removeEventListener?.("abort", abort))
;(res as any).cancel = cancel
return res as any
}