Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate firebase for deployment #727

Merged
merged 5 commits into from
Nov 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .firebaserc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"projects": {
"default": "mobu-waiwai"
}
}
37 changes: 37 additions & 0 deletions .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This file was auto-generated by the Firebase CLI
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on merge
'on':
push:
branches:
- main
paths-ignore:
- '.github/dependabot.yml'
- '.github/workflows/dependency-review.yml'
- '.github/workflows/main.yml'
- '.editorconfig'
- '**.md'
- '.vscode/**'
- 'dprint.json'
- 'renovate.json'
- '.eslintrc.json'
jobs:
build_and_deploy:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
cache: npm
node-version-file: '.node-version'
- name: install dependencies
run: npm ci --ignore-scripts
- run: npm run build
- uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_MOBU_WAIWAI }}'
channelId: live
projectId: mobu-waiwai
37 changes: 37 additions & 0 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This file was auto-generated by the Firebase CLI
# https://github.com/firebase/firebase-tools

name: Deploy to Firebase Hosting on PR
'on':
pull_request:
paths-ignore:
- '.github/dependabot.yml'
- '.github/workflows/dependency-review.yml'
- '.github/workflows/main.yml'
- '.editorconfig'
- '**.md'
- '.vscode/**'
- 'dprint.json'
- 'renovate.json'
- '.eslintrc.json'
jobs:
build_and_preview:
if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
cache: npm
node-version-file: '.node-version'
- name: install dependencies
run: npm ci --ignore-scripts
- name: Specify actual commit ref for revisions
run: echo VITE_COMMIT_REF=${{ github.event.pull_request.head.sha }} > .env
Comment on lines +30 to +31
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firebase actions looks generating special merging commit for internal use. It breaks #444 in staging deploy. So this and https://github.com/mobu-of-the-world/mobu/pull/727/files#r1031619146 is the workaround.

- run: npm run build
- uses: FirebaseExtended/action-hosting-deploy@v0
Comment on lines +32 to +33
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use https://github.com/kachick/wait-other-jobs in my repos just before deploy steps. However excluded in this PR for a simple first step.

with:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_MOBU_WAIWAI }}'
projectId: mobu-waiwai
Comment on lines +35 to +37
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without specified expire, firebase keeps 7 days

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

A web application to manage participants and timer for mob-programming!

Visit here to enjoy: [https://mobu-waiwai.netlify.com](https://mobu-waiwai.netlify.com)
Visit here to enjoy: [https://mobu-waiwai.web.app/](https://mobu-waiwai.web.app/)

## How to start development

Expand Down
10 changes: 10 additions & 0 deletions firebase.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"hosting": {
"public": "build",
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
]
}
}
94 changes: 94 additions & 0 deletions public/404.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<title>Page Not Found</title>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has been generated by firebase CLI


<style media="screen">
body {
background: #eceff1;
color: rgba(0, 0, 0, 0.87);
font-family: Roboto, Helvetica, Arial, sans-serif;
margin: 0;
padding: 0;
}
#message {
background: white;
max-width: 360px;
margin: 100px auto 16px;
padding: 32px 24px 16px;
border-radius: 3px;
}
#message h3 {
color: #888;
font-weight: normal;
font-size: 16px;
margin: 16px 0 12px;
}
#message h2 {
color: #ffa100;
font-weight: bold;
font-size: 16px;
margin: 0 0 8px;
}
#message h1 {
font-size: 22px;
font-weight: 300;
color: rgba(0, 0, 0, 0.6);
margin: 0 0 16px;
}
#message p {
line-height: 140%;
margin: 16px 0 24px;
font-size: 14px;
}
#message a {
display: block;
text-align: center;
background: #039be5;
text-transform: uppercase;
text-decoration: none;
color: white;
padding: 16px;
border-radius: 4px;
}
#message,
#message a {
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.12), 0 1px 2px rgba(0, 0, 0, 0.24);
}
#load {
color: rgba(0, 0, 0, 0.4);
text-align: center;
font-size: 13px;
}
@media (max-width: 600px) {
body,
#message {
margin-top: 0;
background: white;
box-shadow: none;
}
body {
border-top: 16px solid #ffa100;
}
}
</style>
</head>
<body>
<div id="message">
<h2>404</h2>
<h1>Page Not Found</h1>
<p>
The specified file was not found on this website. Please check the URL
for mistakes and try again.
</p>
<h3>Why am I seeing this?</h3>
<p>
This page was generated by the Firebase Command-Line Interface. To
modify it, edit the <code>404.html</code> file in your project's
configured <code>public</code> directory.
</p>
</div>
</body>
</html>
28 changes: 17 additions & 11 deletions vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
import react from "@vitejs/plugin-react";
import { defineConfig } from "vite";
import { defineConfig, loadEnv } from "vite";
import { execSync } from "child_process";

const commitRef = execSync("git rev-parse --short HEAD").toString().trim();

export default defineConfig({
build: {
outDir: "./build",
},
plugins: [react()],
define: {
APP_COMMIT_REF: JSON.stringify(commitRef),
},
export default defineConfig(({ mode }) => {
const env = loadEnv(mode, process.cwd());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import.meta can't be used in vite.config.ts

const commitRef = env["VITE_COMMIT_REF"] ?? execSync("git rev-parse --short HEAD").toString().trim();
const commitShortRef = commitRef.slice(
0,
7,
);
return {
build: {
outDir: "./build",
},
plugins: [react()],
define: {
APP_COMMIT_REF: JSON.stringify(commitShortRef),
},
};
});