New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer as const
with TypeScript 4.9 introduced satisfies
operator
#724
Conversation
Hmm... vite or esbuild looks having issue for this feature 🤔 |
We are using supported esbuild version 🤔 Line 24 in 77a0693
|
esbuild ignores rest of |
To includes babel 7.2.0 https://babeljs.io/blog/2022/10/27/7.20.0
To bump jest to apply jestjs/jest#13199 (comment)
Using old babel is the cause. (Vite using babel for JSX) However roughly updating all to latest makes Jest error. This is a dependency hell 🤣 |
Failed only in netlify integration. Looks using yarn. Replaced yarn with npm in #435. 🤔 @pankona Do you know the reason? I believe deployment should use as same logics tested in CI. How about to replace with others? An example, firebase can use github actions for the deployment. Looks netlify having similar one https://github.com/marketplace/actions/netlify-actions (but this is unofficial) |
Official having actions with few comments https://github.com/netlify/actions/tree/375963b92b795c7b979927c580dd6f2a65ebcf28/build They said It is not maintained https://answers.netlify.com/t/guide-for-deploy-using-github-actions/2981/15 |
Visit the preview URL for this PR (updated for commit 55dd1c6): https://mobu-waiwai--pr724-prefer-as-const-with-ljxb1yh9.web.app (expires Thu, 01 Dec 2022 15:22:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 295e29f2bd6fa9acc70abd1b84aec0de70cff3f6 |
Since replaced netlify with firebae, Blocker is gone. |
microsoft/TypeScript#47920
https://devblogs.microsoft.com/typescript/announcing-typescript-4-9-rc/#satisfies
This is my hope since #479 (comment)
NOTE: typescirpt-eslint has issue for false detection. It is fixed in typescript-eslint/typescript-eslint#6059, but not yer released. However we don't have the pattern. See kachick/renovate-config-asdf#415 (comment) for further detail.