Speed up ledger-from-archive #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugargoat
force-pushed
the
ledger-from-archive-speedup
branch
from
86c1432
to
d19db7e
Compare
sugargoat
force-pushed
the
ledger-from-archive-speedup
branch
from
d19db7e
to
c98ff92
Compare
joekottke
previously approved these changes
May 13, 2021
eranrund
reviewed
May 13, 2021
| loop { | ||
| let end = start + config.block_chunk_size; |
There was a problem hiding this comment.
Shouldn't this be min(start + config.block_chunk_size, config.num_blocks.unwrap_or(u64::maxint))?
eranrund
reviewed
May 13, 2021
| err | ||
| ); | ||
| return; | ||
| .unwrap(); |
eranrund
reviewed
May 13, 2021
| /// | ||
| /// Peers are queried concurrently. Currently, this method will run indefinitely | ||
| /// until all transactions have been retrieved. | ||
| fn get_block_contents( |
There was a problem hiding this comment.
Any reason to copy this entire thing instead of making the one in ledger_sync_service pub?
There was a problem hiding this comment.
Hm, I see that it is less strict so using the one in ledger_sync_service would be difficult.
eranrund
suggested changes
May 13, 2021
| ); | ||
| match transactions_fetcher.block_from_url(&url) { |
There was a problem hiding this comment.
Replacing this call with transactions_fetcher.get_block_data_by_index(block_index, None) should be sufficient for benefiting from the merged blocks and getting the speed increase you are looking for.
|
This still seems useful; do we want to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soundtrack of this PR: I love it
Motivation
Ledger-from-archive is painfully slow, especially on TestNet at 160K blocks currently
In this PR
Future Work