move mc-crypto-rand to be a dev-dependency of mc-transaction-core #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mc-transaction-core` should be as portable as possible, but it had a dependency on `mc-crypto-rand` which is not as portable. Getting an RNG is very hard to do portably -- the approach we use in `mc-crypto-rand` is like, use the standard library approach and the getrandom crate, which still requires an OS, or if you have RDRAND instruction, use that, and selecting between these alternatives is what `mc-crypto-rand` does basically. But this will not work on embedded devices that don't have an OS or intel chips. It just happens to work for all our current enclave phone and server targets. But it may pose a portability problem if someone wanted to build `mc-transaction-core` for a more restricted device. Fortunately the only thing that was creating an RNG directly in `mc-transaction-core`, was the code in the `FogHint` which we removed in mobilecoinfoundation#712 So at this point `mc-transaction-core` only needs `mc-crypto-rand` for tests. Moving it to dev-dependency helps make the transaction core more portable.
kylefleming
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mc-transaction-coreshould be as portable as possible, but it hada dependency on
mc-crypto-randwhich is not as portable.Getting an RNG is very hard to do portably -- the approach we use
in
mc-crypto-randis like, use the standard library approach andthe getrandom crate, which still requires an OS, or if you have
RDRAND instruction, use that, and selecting between these
alternatives is what
mc-crypto-randdoes basically. But this willnot work on embedded devices that don't have an OS or intel chips.
It just happens to work for all our current enclave phone and server
targets. But it may pose a portability problem if someone wanted
to build
mc-transaction-corefor a more restricted device.Fortunately the only thing that was creating an RNG directly in
mc-transaction-core, was the code in theFogHintwhich we removedin #712
So at this point
mc-transaction-coreonly needsmc-crypto-randfor tests. Moving it to dev-dependency helps make the transaction core
more portable.