Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Feat(root): Apply Eslint and Integrate with Prettier #135

Merged
merged 8 commits into from Apr 9, 2021

Conversation

lqt93
Copy link
Contributor

@lqt93 lqt93 commented Apr 9, 2021

@vercel
Copy link

vercel bot commented Apr 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

moai-site – ./site

🔍 Inspect: https://vercel.com/makeinvietnam/moai-site/49G5j2ySHCjMHWQisox4VWoMZCdE
✅ Preview: https://moai-site-git-fork-lqt93-apply-eslint-makeinvietnam.vercel.app

moai-core – ./core

🔍 Inspect: https://vercel.com/makeinvietnam/moai-core/98erpiobSfpyN2HxYcnyjq7wycAf
✅ Preview: https://moai-core-git-fork-lqt93-apply-eslint-makeinvietnam.vercel.app

.eslintrc Outdated
@@ -0,0 +1,20 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note, for libraries that use universal config (i.e. "rc", "json", "js"), we prefer JS (because it has comment) or JSON (because vscode auto has schema for them). The "rc" one is quite limited

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait I'm wrong! VSCode recognize .rc file!

@thien-do thien-do merged commit e88e8f8 into moaijs:main Apr 9, 2021
@lqt93 lqt93 deleted the apply-eslint branch April 11, 2021 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants