Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Exclude pytest 5.4.0 #7438

Merged
merged 2 commits into from Mar 12, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR skips pytest 5.4.0 because of the issues with pytest-sugar.

Closes #7437

@GuillaumeFavelier
Copy link
Contributor Author

I have to remove it from:

- pip install --upgrade pytest pytest-sugar pytest-cov pytest-mock pytest-timeout codecov

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #7438 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7438      +/-   ##
==========================================
+ Coverage   90.05%   90.12%   +0.07%     
==========================================
  Files         454      454              
  Lines       82323    81500     -823     
  Branches    13022    13021       -1     
==========================================
- Hits        74135    73453     -682     
+ Misses       5366     5219     -147     
- Partials     2822     2828       +6     

@GuillaumeFavelier
Copy link
Contributor Author

This should be ready now @larsoner, @agramfort, @drammock

@drammock drammock merged commit debae78 into mne-tools:master Mar 12, 2020
@drammock
Copy link
Member

thanks @GuillaumeFavelier

@GuillaumeFavelier
Copy link
Contributor Author

For reference, I suggested Teemu/pytest-sugar#187 (comment) and twmr/pytest-sphinx#11

@GuillaumeFavelier GuillaumeFavelier deleted the maint_pytest_sugar branch June 11, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest-sugar is not working with pytest v5.4.0 (released on March 12th 2020)
2 participants