Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS: Try to fix CI #361

Merged
merged 3 commits into from Mar 18, 2020
Merged

TESTS: Try to fix CI #361

merged 3 commits into from Mar 18, 2020

Conversation

hoechenberger
Copy link
Member

PR Description

pytest-sugar currently doesn't support pytest 5.4, see Teemu/pytest-sugar#187

Pinning pytest to <5.4 for now to hopefully make CIs work again.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

pytest-sugar currently doesn't support pytest 5.4, see
Teemu/pytest-sugar#187
@GuillaumeFavelier
Copy link

@hoechenberger maybe doc/environment.yml needs to be updated too?

#!/bin/bash -eo pipefail
diff <(grep -v '^  - mne_bids~=0.3$' doc/environment.yml) <(cat environment.yml)

19c19
<   - pytest
---
>   - pytest<5.4

Exited with code exit status 1

CircleCI received exit code 1

@sappelhoff
Copy link
Member

Thanks @hoechenberger! Travis fails because it wants you to keep environment.yml and doc/environment.yml in sync ... so adding the pytest change there will fix travis (at least that single check)

@hoechenberger
Copy link
Member Author

Thanks @sappelhoff and @GuillaumeFavelier

@agramfort
Copy link
Member

we should migrate CIs from appveyor to azure pipelines as it's much faster for windows

any objection?

@hoechenberger
Copy link
Member Author

we should migrate CIs from appveyor to azure pipelines as it's much faster for windows

any objection?

None from my side, but I've never created an Azure pipeline before, so would need a little time to get this to work. Or sb else would have to do it :)

@sappelhoff
Copy link
Member

No objection, but perhaps it can be done the next time we have issues with the CIs ... currently it's working so we can just leave it as they are?

@agramfort
Copy link
Member

agramfort commented Mar 18, 2020 via email

@agramfort agramfort merged commit 007f763 into master Mar 18, 2020
@agramfort
Copy link
Member

thx @hoechenberger

@sappelhoff
Copy link
Member

@agramfort @hoechenberger .. coming back to the CI discussion and moving Appveyor --> Azure Pipelines.

It might be possible that we can test Linux, MacOS, and Windows all using GitHub Actions (https://github.com/features/actions)

image

Just to keep in mind.

Maybe @larsoner knows more about this?

@agramfort
Copy link
Member

agramfort commented Mar 26, 2020 via email

@larsoner
Copy link
Member

Yes you can probably go either way. I have limited direct experience with GitHub actions. It does seem to have some annoying limitations. My guess is that Azure will be easier because there are many existing repos using it that you could use to build up an appropriate azure-pipelines.yml.

@agramfort
Copy link
Member

agramfort commented Mar 26, 2020 via email

@jasmainak
Copy link
Member

I would stay away from github actions for now. Not sure how mature it is ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants