[Runs] Store artifact URIs instead of full artifacts in body [1.6.x] #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSaarco
requested changes
May 12, 2024
mlrun/model.py
Outdated
| @@ -1058,6 +1058,7 @@ def __init__( | |||
| ui_url=None, | |||
| reason: str = None, | |||
| notifications: Dict[str, Notification] = None, | |||
| artifact_uris: list[str] = None, | |||
There was a problem hiding this comment.
This needs to be a dict now, doesn't it?
alonmr
added a commit
to alonmr/mlrun
that referenced
this pull request
May 13, 2024
…lrun#5544) (cherry picked from commit a54892f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-6397
Artifacts stats and preview can bloat the DB when stored in run body.
Instead we now only store the artifact URIs while in memory the run object still holds the artifacts (client side) to maintain easy access.
In the API we strip the artifacts if given and enrich the artifact URIs when storing / updating the runs.
Example from run yaml:
Example from run output html:
