Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Requirements] Bump fastapi and uvicorn #2629

Merged
merged 12 commits into from Jan 1, 2023

Conversation

alonmr
Copy link
Member

@alonmr alonmr commented Nov 28, 2022

Effected changes:

@alonmr alonmr marked this pull request as draft November 28, 2022 12:24
@alonmr alonmr changed the title [requirements] Bump fastapi and uvicorn [Requirements] Bump fastapi and uvicorn Nov 28, 2022
@alonmr alonmr marked this pull request as ready for review November 30, 2022 11:42
@alonmr alonmr marked this pull request as draft November 30, 2022 13:05
@alonmr alonmr marked this pull request as ready for review December 26, 2022 07:08
Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to test the functionality with triggering migrations not via SDK.
And then all's good

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, I would prefer that the from mlrun.api.utils import StrEnum will be changed to import mlrun.api.utils to reduce possibility for circular imports

@alonmr alonmr merged commit 89287d7 into mlrun:development Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants