New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Requirements] Bump fastapi and uvicorn #2629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to test the functionality with triggering migrations not via SDK.
And then all's good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, I would prefer that the from mlrun.api.utils import StrEnum
will be changed to import mlrun.api.utils
to reduce possibility for circular imports
Effected changes:
--debug
flag encode/uvicorn#1640requests
tohttpx
encode/starlette#1376delete
method does not support body - https://www.python-httpx.org/compatibility/#request-body-on-http-methodsrequests
test client is able to encode enums as their values in query parameters. Withhttpx
we no longer have this privilege. TheQueryParams
class not is mapping enums to their values but to their representing string e.g.ProjectsFormat.full
into the string"ProjectsFormat.full"
instead of"full"
.