-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UP031
rule
#8955
Enable UP031
rule
#8955
Conversation
Signed-off-by: harupy <hkawamura0130@gmail.com>
6aaaff8
to
ab67c9d
Compare
Signed-off-by: harupy <hkawamura0130@gmail.com>
Documentation preview for c7726e6 will be available here when this CircleCI job completes successfully. More info
|
mlflow/cli.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ai this is a PR to replace percent formatting with format
or f-string. Tell me mistakes if you find any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harupy The code changes look good. The percent formatting has been replaced correctly with f-strings. The code change seems fine to me.
Click here to see the prompt and usage data
Prompt:
this is a PR to replace percent formatting with `format` or f-string. Tell me mistakes if you find any.
```
a/mlflow/cli.py b/mlflow/cli.py
index d337117898ab..af064d34f80e 100644
--- a/mlflow/cli.py
+++ b/mlflow/cli.py
@@ -236,8 +236,8 @@ def _user_args_to_dict(arguments, argument_type="P"):
value = split[1]
else:
eprint(
- "Invalid format for -%s parameter: '%s'. "
- "Use -%s name=value." % (argument_type, arg, argument_type)
+ f"Invalid format for -{argument_type} parameter: '{arg}'. "
+ f"Use -{argument_type} name=value."
)
sys.exit(1)
if name in user_dict:
```
Usage:
{
"prompt_tokens": 240,
"completion_tokens": 26,
"total_tokens": 266,
"estimated_cost_in_usd": 0.000412
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ai this is a PR to replace percent formatting with format or f-string. Tell me mistakes if you find any.
Signed-off-by: harupy <hkawamura0130@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Enable
UP031
.How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes