Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UP031 rule #8955

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Conversation

harupy
Copy link
Member

@harupy harupy commented Jul 5, 2023

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Enable UP031.

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@harupy harupy changed the title Enable UP031 Enable UP031 rule Jul 5, 2023
Signed-off-by: harupy <hkawamura0130@gmail.com>
@harupy harupy force-pushed the remove-printf-string-formatting branch from 6aaaff8 to ab67c9d Compare July 5, 2023 03:05
Signed-off-by: harupy <hkawamura0130@gmail.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Jul 5, 2023
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Jul 5, 2023

Documentation preview for c7726e6 will be available here when this CircleCI job completes successfully.

More info

mlflow/entities/run_status.py Outdated Show resolved Hide resolved
mlflow/store/artifact/databricks_models_artifact_repo.py Outdated Show resolved Hide resolved
mlflow/utils/search_utils.py Outdated Show resolved Hide resolved
mlflow/cli.py Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ai this is a PR to replace percent formatting with format or f-string. Tell me mistakes if you find any.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harupy The code changes look good. The percent formatting has been replaced correctly with f-strings. The code change seems fine to me.

Click here to see the prompt and usage data

Prompt:

this is a PR to replace percent formatting with `format` or f-string. Tell me mistakes if you find any.

```
a/mlflow/cli.py b/mlflow/cli.py
index d337117898ab..af064d34f80e 100644
--- a/mlflow/cli.py
+++ b/mlflow/cli.py
@@ -236,8 +236,8 @@ def _user_args_to_dict(arguments, argument_type="P"):
             value = split[1]
         else:
             eprint(
-                "Invalid format for -%s parameter: '%s'. "
-                "Use -%s name=value." % (argument_type, arg, argument_type)
+                f"Invalid format for -{argument_type} parameter: '{arg}'. "
+                f"Use -{argument_type} name=value."
             )
             sys.exit(1)
         if name in user_dict:

```

Usage:

{
  "prompt_tokens": 240,
  "completion_tokens": 26,
  "total_tokens": 266,
  "estimated_cost_in_usd": 0.000412
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ai this is a PR to replace percent formatting with format or f-string. Tell me mistakes if you find any.

@mlflow mlflow deleted a comment from mlflow bot Jul 5, 2023
Signed-off-by: harupy <hkawamura0130@gmail.com>
Copy link
Collaborator

@gabrielfu gabrielfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harupy harupy enabled auto-merge (squash) July 5, 2023 03:44
@harupy harupy added the only-latest If applied, only test the latest version of each group in cross-version tests. label Jul 5, 2023
@harupy harupy merged commit 6e17ee0 into mlflow:master Jul 5, 2023
47 of 78 checks passed
@harupy harupy deleted the remove-printf-string-formatting branch July 5, 2023 05:07
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Jul 5, 2023
* Enable UP031

Signed-off-by: harupy <hkawamura0130@gmail.com>

* Use f-string

Signed-off-by: harupy <hkawamura0130@gmail.com>

* Address comments

Signed-off-by: harupy <hkawamura0130@gmail.com>

---------

Signed-off-by: harupy <hkawamura0130@gmail.com>
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Jul 7, 2023
* Enable UP031

Signed-off-by: harupy <hkawamura0130@gmail.com>

* Use f-string

Signed-off-by: harupy <hkawamura0130@gmail.com>

* Address comments

Signed-off-by: harupy <hkawamura0130@gmail.com>

---------

Signed-off-by: harupy <hkawamura0130@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
only-latest If applied, only test the latest version of each group in cross-version tests. rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants