Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mkstemp to replace deprecated mktemp call #5303

Merged
merged 4 commits into from Jan 26, 2022
Merged

Use mkstemp to replace deprecated mktemp call #5303

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f59f0c2
Use mkstemp
dbczumar Jan 24, 2022
fa68186
Remove num examples
dbczumar Jan 24, 2022
0d4274c
Close instead of remove
dbczumar Jan 26, 2022
78e75b5
Close the handle
dbczumar Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlflow/utils/file_utils.py
View file
Open in desktop
Expand Up @@ -287,7 +287,7 @@ def _filter_timestamps(tar_info):
tar_info.mtime = 0
return tar_info if custom_filter is None else custom_filter(tar_info)

unzipped_filename = tempfile.mktemp()
_, unzipped_filename = tempfile.mkstemp()
Copy link
Member

@harupy harupy Jan 25, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/34716996/cant-remove-a-file-which-created-by-tempfile-mkstemp-on-windows says os.close can solve the permission error on windows.

    _, unzipped_filename = tempfile.mkstemp()
    try:
        with tarfile.open(unzipped_filename, "w") as tar:
            tar.add(source_dir, arcname=archive_name, filter=_filter_timestamps)
        # When gzipping the tar, don't include the tar's filename or modification time in the
        # zipped archive (see https://docs.python.org/3/library/gzip.html#gzip.GzipFile)
        with gzip.GzipFile(
            filename="", fileobj=open(output_filename, "wb"), mode="wb", mtime=0
        ) as gzipped_tar, open(unzipped_filename, "rb") as tar:
            gzipped_tar.write(tar.read())
    finally:
+       os.close(unzipped_filename)
        os.remove(unzipped_filename)

try:
with tarfile.open(unzipped_filename, "w") as tar:
tar.add(source_dir, arcname=archive_name, filter=_filter_timestamps)
Expand Down