Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve evaluation api #5256

Merged
merged 14 commits into from Jan 14, 2022
Merged

Improve evaluation api #5256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a25d335
init
WeichenXu123 Jan 12, 2022
d9088b9
update
WeichenXu123 Jan 12, 2022
e367960
update
WeichenXu123 Jan 12, 2022
308568f
update doc
WeichenXu123 Jan 12, 2022
37b3c69
update doc
WeichenXu123 Jan 12, 2022
1659320
address comments
WeichenXu123 Jan 13, 2022
77c5e51
update doc
WeichenXu123 Jan 13, 2022
fbdecff
add shap limitation on value type
WeichenXu123 Jan 13, 2022
953612f
fix format
WeichenXu123 Jan 13, 2022
3572198
update
WeichenXu123 Jan 13, 2022
99146cf
update
WeichenXu123 Jan 13, 2022
8cd1182
update
WeichenXu123 Jan 14, 2022
9a40df3
update
WeichenXu123 Jan 14, 2022
c3ae623
update
WeichenXu123 Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions docs/source/python_api/mlflow.models.evaluation.base.rst
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions docs/source/python_api/mlflow.models.evaluation.rst
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions mlflow/models/__init__.py
View file
Open in desktop
Expand Up @@ -24,14 +24,16 @@
from .model import Model
from .flavor_backend import FlavorBackend
from ..utils.environment import infer_pip_requirements
from .evaluation import evaluate, EvaluationDataset
from .evaluation import evaluate, EvaluationArtifact, EvaluationResult, list_evaluators

__all__ = [
"Model",
"FlavorBackend",
"infer_pip_requirements",
"evaluate",
"EvaluationDataset",
"EvaluationArtifact",
"EvaluationResult",
"list_evaluators",
]


Expand Down
2 changes: 0 additions & 2 deletions mlflow/models/evaluation/__init__.py
View file
Open in desktop
Expand Up @@ -2,7 +2,6 @@
ModelEvaluator,
EvaluationDataset,
EvaluationResult,
EvaluationMetrics,
EvaluationArtifact,
evaluate,
list_evaluators,
Expand All @@ -12,7 +11,6 @@
"ModelEvaluator",
"EvaluationDataset",
"EvaluationResult",
"EvaluationMetrics",
"EvaluationArtifact",
"evaluate",
"list_evaluators",
Expand Down
4 changes: 2 additions & 2 deletions mlflow/models/evaluation/artifacts.py
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@


class ImageEvaluationArtifact(EvaluationArtifact):
def save(self, output_artifact_path):
def _save(self, output_artifact_path):
self._content.save(output_artifact_path)

def _load_content_from_file(self, local_artifact_path):
Expand All @@ -15,7 +15,7 @@ def _load_content_from_file(self, local_artifact_path):


class CsvEvaluationArtifact(EvaluationArtifact):
def save(self, output_artifact_path):
def _save(self, output_artifact_path):
self._content.to_csv(output_artifact_path, index=False)

def _load_content_from_file(self, local_artifact_path):
Expand Down