New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin alembic #5249
Unpin alembic #5249
Changes from all commits
e7e9c7d
74550f2
18d4d96
e751253
a104bb0
53ff3ca
842381b
a9816b6
cf5df44
9154b76
305236c
bc40149
79e0105
2c22ed7
9437139
c95094c
de28923
aa3c502
85b74e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,21 +161,20 @@ jobs: | |
./dev/run-large-python-tests.sh | ||
# Separate build and run to make it easier to explore logs | ||
- name: Run database initialization tests - build | ||
working-directory: tests/db | ||
run: | | ||
python setup.py bdist_wheel | ||
cp -r dist tests/db | ||
cd tests/db | ||
./build_wheel.sh | ||
docker-compose pull | ||
docker image ls | grep -E '(REPOSITORY|postgres|mysql|mssql)' | ||
docker-compose build | ||
- name: Run database initialization tests - run | ||
working-directory: tests/db | ||
run: | | ||
docker-compose run mlflow-sqlite python run_checks.py --schema-output schemas/sqlite.sql | ||
docker-compose run mlflow-postgres python run_checks.py --schema-output schemas/postgres.sql | ||
docker-compose run mlflow-mysql python run_checks.py --schema-output schemas/mysql.sql | ||
docker-compose run mlflow-mssql ./init-mssql-db.sh | ||
docker-compose run mlflow-mssql python run_checks.py --schema-output schemas/mssql.sql | ||
docker-compose down --rmi all --volumes --remove-orphans | ||
docker-compose run mlflow-sqlite | ||
docker-compose run mlflow-postgres | ||
docker-compose run mlflow-mysql | ||
docker-compose run mlflow-mssql | ||
docker-compose down --volumes --remove-orphans --rmi all | ||
Comment on lines
-173
to
+177
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cleaned up this step by adding commands in docker-compose.yml. |
||
- name: Run anaconda compatibility tests | ||
run: | | ||
./dev/test-anaconda-compatibility.sh "anaconda3:2020.11" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ def package_files(directory): | |
other capabilities. | ||
""" | ||
CORE_REQUIREMENTS = SKINNY_REQUIREMENTS + [ | ||
"alembic<=1.4.1", | ||
"alembic", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 |
||
# Required | ||
"docker>=4.0.0", | ||
"Flask", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,7 @@ FROM python:3.6 | |
|
||
WORKDIR /tmp/mlflow | ||
|
||
COPY dist ./dist | ||
|
||
RUN pip install dist/*.whl | ||
RUN pip install psycopg2 pymysql mysqlclient | ||
COPY dist ./dist | ||
RUN pip install dist/mlflow-*.whl | ||
Comment on lines
-5
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For rebuilding the image a bit faster. |
||
RUN pip list |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -ex | ||
|
||
rm -rf dist | ||
prefix=$(git rev-parse --show-prefix) | ||
pushd $(git rev-parse --show-cdup) | ||
python setup.py bdist_wheel --dist-dir $prefix/dist | ||
popd |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,15 +17,17 @@ services: | |
- .:/tmp/mlflow | ||
environment: | ||
MLFLOW_TRACKING_URI: postgresql://mlflowuser:mlflowpassword@postgres:5432/mlflowdb | ||
command: python run_checks.py --schema-output schemas/postgres.sql | ||
|
||
mysql: | ||
image: mysql:5.7 | ||
image: mysql | ||
restart: always | ||
environment: | ||
MYSQL_ROOT_PASSWORD: root-password | ||
MYSQL_DATABASE: mlflowdb | ||
MYSQL_USER: mlflowuser | ||
MYSQL_PASSWORD: mlflowpassword | ||
command: mysqld --default-authentication-plugin=mysql_native_password | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In MySQL >= 8.0.4, this command is required to log in using a password. |
||
|
||
mlflow-mysql: | ||
depends_on: | ||
|
@@ -36,6 +38,7 @@ services: | |
- .:/tmp/mlflow | ||
environment: | ||
MLFLOW_TRACKING_URI: mysql://mlflowuser:mlflowpassword@mysql:3306/mlflowdb | ||
command: python run_checks.py --schema-output schemas/mysql.sql | ||
|
||
mssql: | ||
image: mcr.microsoft.com/mssql/server | ||
|
@@ -54,6 +57,7 @@ services: | |
- .:/tmp/mlflow | ||
environment: | ||
MLFLOW_TRACKING_URI: mssql+pyodbc://mlflowuser:Mlfl*wpassword1@mssql/mlflowdb?driver=ODBC+Driver+17+for+SQL+Server | ||
command: bash -ex -c "./init-mssql-db.sh && python run_checks.py --schema-output schemas/mssql.sql" | ||
|
||
mlflow-sqlite: | ||
depends_on: | ||
|
@@ -64,3 +68,4 @@ services: | |
- .:/tmp/mlflow | ||
environment: | ||
MLFLOW_TRACKING_URI: sqlite:////tmp/mlflow/mlflowdb | ||
command: python run_checks.py --schema-output schemas/sqlite.sql |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,12 @@ def run_logging_operations(): | |
) | ||
print(mlflow.get_run(run.info.run_id)) | ||
|
||
# Ensure the following migration scripts work correctly: | ||
# - cfd24bdc0731_update_run_status_constraint_with_killed.py | ||
# - 0a8213491aaa_drop_duplicate_killed_constraint.py | ||
client = mlflow.tracking.MlflowClient() | ||
client.set_terminated(run_id=run.info.run_id, status="KILLED") | ||
Comment on lines
+38
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a check to ensure the updated migration scripts work properly. |
||
|
||
|
||
def get_db_schema(): | ||
engine = sqlalchemy.create_engine(mlflow.get_tracking_uri()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show database image versions for debugging.