Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python 3.8 for when running tests for dev version of statsmodels #5235

Merged
merged 3 commits into from Jan 7, 2022
Merged

Use python 3.8 for when running tests for dev version of statsmodels #5235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61bec96
Use python 3.8 for dev version of statsmodels
harupy Jan 7, 2022
7a1a00f
sort imports
harupy Jan 7, 2022
c11ac00
fix if syntax
harupy Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/setup-python/action.yml
View file
Open in desktop
Expand Up @@ -24,8 +24,10 @@ runs:
python_version="3.6.13"
elif [[ "$python_version" == "3.7" ]]; then
python_version="3.7.12"
elif [[ "$python_version" == "3.8" ]]; then
python_version="3.8.12"
else
echo "Invalid python version: '$python_version'. Must be one of ['3.6', '3.7']"
echo "Invalid python version: '$python_version'. Must be one of ['3.6', '3.7', '3.8']"
exit 1
fi
echo "::set-output name=version::$python_version"
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/cross-version-tests.yml
View file
Open in desktop
Expand Up @@ -112,7 +112,10 @@ jobs:
- name: Get python version
id: get-python-version
run: |
if [[ "${{ matrix.version }}" = "dev" ]] || \
if [[ "${{ matrix.package }}" = "statsmodels" && "${{ matrix.version }}" = "dev" ]]
then
python_version=3.8
elif [[ "${{ matrix.version }}" = "dev" ]] || \
[[ "${{ matrix.package }}" = "scikit-learn" && ! "${{ matrix.version }}" =~ ^0\.* ]] || \
[[ "${{ matrix.package }}" = "statsmodels" ]] || \
[[ "${{ matrix.package }}" = "tensorflow" && ! "${{ matrix.version }}" =~ ^2\.[0-6] ]] || \
Expand Down
2 changes: 1 addition & 1 deletion mlflow/statsmodels.py
View file
Open in desktop
Expand Up @@ -12,9 +12,9 @@
https://www.statsmodels.org/stable/_modules/statsmodels/base/model.html#Results

"""
import logging
import os
import yaml
import logging

import mlflow
from mlflow import pyfunc
Expand Down