Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not modify tags dict on start_run() #5191

Merged
merged 4 commits into from Dec 23, 2021
Merged

Do not modify tags dict on start_run() #5191

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c85023
Do not modify tags dict on start_run()
Dec 21, 2021
355fcd4
Do not rewrite tags param on create_run()
Dec 22, 2021
f4679c6
Rename variable in start_run()
Dec 22, 2021
18fffc1
Revert "Do not rewrite tags param on create_run()"
Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions mlflow/tracking/fluent.py
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@
import time
import logging
import inspect
from copy import deepcopy
from packaging.version import Version
from typing import Any, Dict, List, Optional, Union, TYPE_CHECKING

Expand Down Expand Up @@ -278,15 +279,15 @@ def start_run(

exp_id_for_run = experiment_id if experiment_id is not None else _get_experiment_id()

user_specified_tags = tags or {}
user_specified_tags = deepcopy(tags) or {}
harupy marked this conversation as resolved.
Show resolved Hide resolved
if parent_run_id is not None:
user_specified_tags[MLFLOW_PARENT_RUN_ID] = parent_run_id
if run_name is not None:
user_specified_tags[MLFLOW_RUN_NAME] = run_name

tags = context_registry.resolve_tags(user_specified_tags)
run_tags = context_registry.resolve_tags(user_specified_tags)
matheusMoreno marked this conversation as resolved.
Show resolved Hide resolved

active_run_obj = client.create_run(experiment_id=exp_id_for_run, tags=tags)
active_run_obj = client.create_run(experiment_id=exp_id_for_run, tags=run_tags)

_active_run_stack.append(ActiveRun(active_run_obj))
return _active_run_stack[-1]
Expand Down