Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pip requrements infer error handling #5176

Merged
merged 6 commits into from Dec 17, 2021
Merged

Improve pip requrements infer error handling #5176

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d57c97
init
WeichenXu123 Dec 16, 2021
f0421c4
update
WeichenXu123 Dec 16, 2021
bf610a1
update
WeichenXu123 Dec 16, 2021
a42a1e7
update
WeichenXu123 Dec 16, 2021
9036a03
update
WeichenXu123 Dec 16, 2021
1cb7c64
Autoformat: https://github.com/mlflow/mlflow/actions/runs/1587443466
mlflow-automation Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions mlflow/utils/environment.py
View file
Open in desktop
Expand Up @@ -175,7 +175,8 @@ def _is_iterable(x):


_INFER_PIP_REQUIREMENTS_FALLBACK_MESSAGE = (
"Encountered an unexpected error while inferring pip requirements (model URI: %s, flavor: %s)"
"Encountered an unexpected error while inferring pip requirements (model URI: %s, flavor: %s),"
" fallback to generate default pip requirements."
WeichenXu123 marked this conversation as resolved.
Show resolved Hide resolved
)


Expand All @@ -194,7 +195,13 @@ def infer_pip_requirements(model_uri, flavor, fallback=None):
return _infer_requirements(model_uri, flavor)
except Exception:
if fallback is not None:
_logger.exception(_INFER_PIP_REQUIREMENTS_FALLBACK_MESSAGE, model_uri, flavor)
if _logger.level <= logging.DEBUG:
_logger.debug(_INFER_PIP_REQUIREMENTS_FALLBACK_MESSAGE,
model_uri, flavor, exc_info=True)
else:
_logger.warning(_INFER_PIP_REQUIREMENTS_FALLBACK_MESSAGE +
' Set log level to be DEBUG to get more information.',
model_uri, flavor)
WeichenXu123 marked this conversation as resolved.
Show resolved Hide resolved
return fallback
raise

Expand Down