Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model_uuid to Java Model #5165

Merged
merged 8 commits into from Dec 15, 2021
Merged

Add model_uuid to Java Model #5165

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a93307d
add model_uuid
harupy Dec 14, 2021
209eca4
rename
harupy Dec 14, 2021
c659a89
test
harupy Dec 14, 2021
3451c24
uncomment
harupy Dec 14, 2021
05ac51b
add test
harupy Dec 15, 2021
6b246d4
update tests
harupy Dec 15, 2021
98ebc1e
set model uuid
harupy Dec 15, 2021
290a9d6
address comments
harupy Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions mlflow/java/scoring/src/main/java/org/mlflow/models/Model.java
View file
Open in desktop
Expand Up @@ -41,6 +41,9 @@ public static class Signature {
@JsonProperty("input_example")
private Map<String, Object> input_example;

@JsonProperty("model_uuid")
private String modelUuid;

private String rootPath;

/**
Expand Down Expand Up @@ -82,6 +85,11 @@ public Optional<String> getRunId() {
return Optional.ofNullable(this.runId);
}

/** @return The MLflow model's uuid */
public Optional<String> getModelUuid() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: <4 Acronym naming convention in Java typically preserves the upper case acronym, particularly if the std library preserves.

public Optional<String> getModelUUID() {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenWilson2 Can we use getModelUuid since we already have getRunUuid?

mlflow/mlflow/server/js/src/experiment-tracking/reducers/Reducers.test.js

Line 166 in c635d1a

[runA.getRunUuid()]: runA,

return Optional.ofNullable(this.modelUuid);
}

/** @return The path to the root directory of the MLflow model */
public Optional<String> getRootPath() {
return Optional.ofNullable(this.rootPath);
Expand Down
1 change: 1 addition & 0 deletions mlflow/java/scoring/src/test/java/org/mlflow/ModelTest.java
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ public void testModelIsLoadedFromYamlUsingConfigPathCorrectly() {
Model model = Model.fromConfigPath(configPath);
Assert.assertTrue(model.getFlavor(MLeapFlavor.FLAVOR_NAME, MLeapFlavor.class).isPresent());
Assert.assertTrue(model.getUtcTimeCreated().isPresent());
Assert.assertTrue(model.getModelUuid().isPresent());
} catch (IOException e) {
e.printStackTrace();
Assert.fail("Encountered an exception while reading the model from a configuration path!");
Expand Down
2 changes: 0 additions & 2 deletions mlflow/mleap.py
View file
Open in desktop
Expand Up @@ -182,8 +182,6 @@ def save_model(
model. The given example will be converted to a Pandas DataFrame and then
serialized to json using the Pandas split-oriented format. Bytes are
base64-encoded.


"""
if mlflow_model is None:
mlflow_model = Model()
Expand Down