Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mleap to Enhances section in DESCRIPTION #5162

Merged
merged 4 commits into from Dec 14, 2021
Merged

Move mleap to Enhances section in DESCRIPTION #5162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bbf605
Remove mleap from DESCRIPTION file
harupy Dec 14, 2021
58374fc
install mleap from archive
harupy Dec 14, 2021
56ebf3a
comment
harupy Dec 14, 2021
f8553a8
try Enhances
harupy Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/master.yml
View file
Open in desktop
Expand Up @@ -106,6 +106,9 @@ jobs:
run: |
install.packages("devtools")
remotes::install_deps('mlflow/R/mlflow', dependencies = TRUE, upgrade = FALSE)
# Install `mleap` from archive since it's unavailable on the CRAN repository:
# https://cran.r-project.org/package=mleap
devtools::install_url("https://cran.r-project.org/src/contrib/Archive/mleap/mleap_1.0.0.tar.gz")
harupy marked this conversation as resolved.
Show resolved Hide resolved
shell: Rscript {0}
- name: Create test environment
run: |
Expand Down
3 changes: 2 additions & 1 deletion mlflow/R/mlflow/DESCRIPTION
View file
Open in desktop
Expand Up @@ -55,11 +55,12 @@ Suggests:
h2o,
keras,
lintr,
mleap,
sparklyr,
stringi (< 1.4.4),
testthat (>= 2.0.0),
xgboost
Enhances:
mleap
Comment on lines +62 to +63
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this section, R CMD check would complain:

https://github.com/mlflow/mlflow/runs/4514454297?check_suite_focus=true#step:14:197

── R CMD check results ────────────────────────────────────── mlflow 1.22.1 ────
Duration: 42s

❯ checking dependencies in R code ... WARNING
Warning:   '::' or ':::' import not declared from: ‘mleap’

Copy link
Member Author

@harupy harupy Dec 14, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Package-Dependencies explains what the Enhances field means:

Finally, the ‘Enhances’ field lists packages “enhanced” by the package at hand, e.g., by providing methods for classes from these packages, or ways to handle objects from these packages (so several packages have ‘Enhances: chron’ because they can handle datetime objects from chron even though they prefer R’s native datetime functions). Version requirements can be specified, but are currently not used. Such packages cannot be required to check the package: any tests which use them must be conditional on the presence of the package. (If your tests use e.g. a dataset from another package it should be in ‘Suggests’ and not ‘Enhances’.)

Not sure if this is the right approach to suppress the error above.

Encoding: UTF-8
RoxygenNote: 7.1.2
Collate:
Expand Down