Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove param 'verbose_eval' in lightgbm version > 3.3.1 #5160

Merged
merged 1 commit into from Dec 13, 2021
Merged

Remove param 'verbose_eval' in lightgbm version > 3.3.1 #5160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 11 additions & 5 deletions tests/lightgbm/test_lightgbm_autolog.py
View file
Open in desktop
Expand Up @@ -76,15 +76,18 @@ def test_lgb_autolog_logs_default_params(bst_params, train_set):
"num_boost_round": 100,
"feature_name": "auto",
"categorical_feature": "auto",
"verbose_eval": (
"keep_training_booster": False,
}
if Version(lgb.__version__) <= Version("3.3.1"):
# The parameter `verbose_eval` in `lightgbm.train` is removed in this PR:
# https://github.com/microsoft/LightGBM/pull/4878
expected_params["verbose_eval"] = (
# The default value of `verbose_eval` in `lightgbm.train` has been changed to 'warn'
# in this PR: https://github.com/microsoft/LightGBM/pull/4577
"warn"
if Version(lgb.__version__) > Version("3.2.1")
else True
),
"keep_training_booster": False,
}
)
expected_params.update(bst_params)

for key, val in expected_params.items():
Expand Down Expand Up @@ -114,8 +117,11 @@ def test_lgb_autolog_logs_specified_params(bst_params, train_set):
expected_params = {
"num_boost_round": 10,
"early_stopping_rounds": 5,
"verbose_eval": False,
}
if Version(lgb.__version__) <= Version("3.3.1"):
# The parameter `verbose_eval` in `lightgbm.train` is removed in this PR:
# https://github.com/microsoft/LightGBM/pull/4878
expected_params["verbose_eval"] = False
lgb.train(bst_params, train_set, valid_sets=[train_set], **expected_params)
run = get_latest_run()
params = run.data.params
Expand Down