Add share button in experiment view (#4936)

* Add share button in experiment view Signed-off-by: Marijn Valk <marijncv@hotmail.com> * wrapper updateUrlWithViewState Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Added lifecycle & modelVersions to urlstate Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Updated share button placement Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Fix tooltip Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Update url to current state before copy Signed-off-by: Marijn Valk <marijncv@hotmail.com> * urlState in ExperimentPage Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Lift urlstate into experimentpage Signed-off-by: Marijn Valk <marijncv@hotmail.com> * lint fix Signed-off-by: Marijn Valk <marijncv@hotmail.com> * fix tests Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Tests added Signed-off-by: Marijn Valk <marijncv@hotmail.com> * extract-i18n:base Signed-off-by: Marijn Valk <marijncv@hotmail.com> * direct ref to prop Signed-off-by: Marijn Valk <marijncv@hotmail.com> * revert headerbutton export Signed-off-by: Marijn Valk <marijncv@hotmail.com> * refactor getDerivedStateFromProps Signed-off-by: Marijn Valk <marijncv@hotmail.com> * local style for sharebutton Signed-off-by: Marijn Valk <marijncv@hotmail.com> * Kick CI Signed-off-by: dbczumar <corey.zumar@databricks.com> Co-authored-by: dbczumar <corey.zumar@databricks.com>
mlflow · Nov 24, 2021 · de01531 · de01531
1 parent 36b56cf
commit de01531
Show file tree

Hide file tree

Showing 9 changed files with 1,129 additions and 458 deletions.
diff --git a/mlflow/server/js/src/common/utils/Utils.js b/mlflow/server/js/src/common/utils/Utils.js
@@ -711,10 +711,9 @@ class Utils {
 
   static getSearchParamsFromUrl(search) {
     const params = qs.parse(search, { ignoreQueryPrefix: true });
-    const str = JSON.stringify(params, function replaceUndefined(key, value) {
-      return value === undefined ? '' : value;
+    const str = JSON.stringify(params, function replaceUndefinedAndBools(key, value) {
+      return value === undefined ? '' : value === 'true' ? true : value === 'false' ? false : value;
     });
-
     return params ? JSON.parse(str) : [];
   }
 

diff --git a/mlflow/server/js/src/common/utils/Utils.test.js b/mlflow/server/js/src/common/utils/Utils.test.js
@@ -462,6 +462,7 @@ test('getSearchParamsFromUrl', () => {
   const url1 = '?p=&q=&r=';
   const url2 = '?';
   const url3 = '?searchInput=some-Input';
+  const url4 = '?boolVal1=true&boolVal2=false';
   expect(Utils.getSearchParamsFromUrl(url0)).toEqual({
     searchInput: '',
   });
@@ -470,6 +471,10 @@ test('getSearchParamsFromUrl', () => {
   expect(Utils.getSearchParamsFromUrl(url3)).toEqual({
     searchInput: 'some-Input',
   });
+  expect(Utils.getSearchParamsFromUrl(url4)).toEqual({
+    boolVal1: true,
+    boolVal2: false,
+  });
 });
 
 test('getSearchUrlFromState', () => {