Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
Signed-off-by: harupy <hkawamura0130@gmail.com>
  • Loading branch information
harupy committed Jan 12, 2022
1 parent 1c0e658 commit 5d9a947
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions .github/workflows/cross-version-testing.md
Expand Up @@ -28,7 +28,7 @@ Cross version testing is a testing strategy to ensure ML integrations in MLflow
sklearn:
package_info:
# [Required] `pip_release` specifies the package this integration depends on.
pip_release: "scikit-learn"
pip_release: 'scikit-learn'

# [Optional] `install_dev` specifies a set of commands to install the dev version of the package.
# For example, the command below builds a wheel from the latest main branch of
Expand All @@ -48,17 +48,17 @@ sklearn:
# For example, '">= 0.24.0": ["xgboost"]' is interpreted as 'if the version of scikit-learn
# to install is newer than or equal to 0.24.0, install xgboost'.
requirements:
">= 0.24.0": ["xgboost"]
'>= 0.24.0': ['xgboost']

# [Required] `minimum` specifies the minimum supported version for the latest release of MLflow.
minimum: "0.20.3"
minimum: '0.20.3'

# [Required] `maximum` specifies the maximum supported version for the latest release of MLflow.
maximum: "1.0"
maximum: '1.0'

# [Optional] `unsupported` specifies a list of versions that should NOT be supported due to
# unacceptable issues or bugs.
unsupported: ["0.21.3"]
unsupported: ['0.21.3']

# [Required] `run` specifies a set of commands to run tests.
run: |
Expand Down Expand Up @@ -114,8 +114,9 @@ the previous section:

## Why do we run tests against development versions?

In cross-version testing, we daily run tests against not only publicly available versions but also
development versions installed from GitHub or nightly wheels. This section explains why.
In cross-version testing, we run daily tests against both publicly available and pre-release
development versions for all dependent libraries that are used by MLflow.
This section explains why.

### Without dev version test

Expand All @@ -134,7 +135,7 @@ First, let's take a look at what would happen **without** dev version test.
time
```

- We can't notice the change until XGBoost 1.5.0 is released.
- We didn't notice the change until after XGBoost 1.5.0 was released.
- MLflow 1.20.0 doesn't work with XGBoost 1.5.0.

### With dev version test
Expand Down

0 comments on commit 5d9a947

Please sign in to comment.