Skip to content

Commit

Permalink
Do not modify tags dict on start_run() (#5191)
Browse files Browse the repository at this point in the history
* Do not modify tags dict on start_run()

Signed-off-by: Matheus Moreno <matheus.moreno@hurb.com>

* Do not rewrite tags param on create_run()

Signed-off-by: Matheus Moreno <matheus.moreno@hurb.com>

* Rename variable in start_run()

Signed-off-by: Matheus Moreno <matheus.moreno@hurb.com>

* Revert "Do not rewrite tags param on create_run()"

This reverts commit 355fcd4.

Signed-off-by: Matheus Moreno <matheus.moreno@hurb.com>
  • Loading branch information
matheusMoreno committed Dec 23, 2021
1 parent 4deb9b7 commit 4c5bdaa
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions mlflow/tracking/fluent.py
Expand Up @@ -8,6 +8,7 @@
import time
import logging
import inspect
from copy import deepcopy
from packaging.version import Version
from typing import Any, Dict, List, Optional, Union, TYPE_CHECKING

Expand Down Expand Up @@ -278,15 +279,15 @@ def start_run(

exp_id_for_run = experiment_id if experiment_id is not None else _get_experiment_id()

user_specified_tags = tags or {}
user_specified_tags = deepcopy(tags) or {}
if parent_run_id is not None:
user_specified_tags[MLFLOW_PARENT_RUN_ID] = parent_run_id
if run_name is not None:
user_specified_tags[MLFLOW_RUN_NAME] = run_name

tags = context_registry.resolve_tags(user_specified_tags)
resolved_tags = context_registry.resolve_tags(user_specified_tags)

active_run_obj = client.create_run(experiment_id=exp_id_for_run, tags=tags)
active_run_obj = client.create_run(experiment_id=exp_id_for_run, tags=resolved_tags)

_active_run_stack.append(ActiveRun(active_run_obj))
return _active_run_stack[-1]
Expand Down

0 comments on commit 4c5bdaa

Please sign in to comment.