Skip to content

Commit

Permalink
Use python 3.8 for when running tests for dev version of statsmodels (
Browse files Browse the repository at this point in the history
#5235)

* Use python 3.8 for dev version of statsmodels

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* sort imports

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

* fix if syntax

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
  • Loading branch information
harupy committed Jan 7, 2022
1 parent cef0ba6 commit 170f5c3
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
4 changes: 3 additions & 1 deletion .github/actions/setup-python/action.yml
Expand Up @@ -24,8 +24,10 @@ runs:
python_version="3.6.13"
elif [[ "$python_version" == "3.7" ]]; then
python_version="3.7.12"
elif [[ "$python_version" == "3.8" ]]; then
python_version="3.8.12"
else
echo "Invalid python version: '$python_version'. Must be one of ['3.6', '3.7']"
echo "Invalid python version: '$python_version'. Must be one of ['3.6', '3.7', '3.8']"
exit 1
fi
echo "::set-output name=version::$python_version"
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/cross-version-tests.yml
Expand Up @@ -112,7 +112,10 @@ jobs:
- name: Get python version
id: get-python-version
run: |
if [[ "${{ matrix.version }}" = "dev" ]] || \
if [[ "${{ matrix.package }}" = "statsmodels" && "${{ matrix.version }}" = "dev" ]]
then
python_version=3.8
elif [[ "${{ matrix.version }}" = "dev" ]] || \
[[ "${{ matrix.package }}" = "scikit-learn" && ! "${{ matrix.version }}" =~ ^0\.* ]] || \
[[ "${{ matrix.package }}" = "statsmodels" ]] || \
[[ "${{ matrix.package }}" = "tensorflow" && ! "${{ matrix.version }}" =~ ^2\.[0-6] ]] || \
Expand Down
2 changes: 1 addition & 1 deletion mlflow/statsmodels.py
Expand Up @@ -12,9 +12,9 @@
https://www.statsmodels.org/stable/_modules/statsmodels/base/model.html#Results
"""
import logging
import os
import yaml
import logging

import mlflow
from mlflow import pyfunc
Expand Down

0 comments on commit 170f5c3

Please sign in to comment.