Run python 3.7 when running dev cross version tests

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
mlflow · Dec 17, 2021 · 111e890 · 111e890
1 parent a68de12
commit 111e890
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/cross-version-tests.yml b/.github/workflows/cross-version-tests.yml
@@ -112,7 +112,8 @@ jobs:
       - name: Get python version
         id: get-python-version
         run: |
-          if [[ "${{ matrix.package }}" = "scikit-learn" && ! "${{ matrix.version }}" =~ ^0\.* ]] || \
+          if [[ "${{ matrix.version }}" = "dev" ]] || \
+             [[ "${{ matrix.package }}" = "scikit-learn" && ! "${{ matrix.version }}" =~ ^0\.* ]] || \
              [[ "${{ matrix.package }}" = "statsmodels" ]] || \
              [[ "${{ matrix.package }}" = "tensorflow" && ! "${{ matrix.version }}" =~ ^2\.[0-6] ]] || \
              [[ "${{ matrix.package }}" = "keras" && ! "${{ matrix.version }}" =~ ^2\.[0-6] ]]

diff --git a/mlflow/pyspark/ml/__init__.py b/mlflow/pyspark/ml/__init__.py
@@ -266,10 +266,7 @@ def _get_instance_param_map_recursively(instance, level, uid_to_indexed_name_map
     is_pipeline = isinstance(instance, Pipeline)
     is_parameter_search_estimator = _is_parameter_search_estimator(instance)
 
-    if level == 0:
-        logged_param_name_prefix = ""
-    else:
-        logged_param_name_prefix = uid_to_indexed_name_map[instance.uid] + "."
+    logged_param_name_prefix = "" if level == 0 else uid_to_indexed_name_map[instance.uid] + "."
 
     for param_name, param_value in param_map.items():
         logged_param_name = logged_param_name_prefix + param_name