Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No files matching yarn format mac/windows fix #120

Merged

Conversation

yannde
Copy link
Contributor

@yannde yannde commented Sep 27, 2021

fix #119

What are you adding?

Modified format and lint in package.json so they work in both mac and windows environments

@yukinoda yukinoda self-requested a review September 27, 2021 03:25
@yukinoda
Copy link
Contributor

yukinoda commented Sep 27, 2021

@jacksonjp should we add a second review?
#122

@yukinoda yukinoda added the bug Something isn't working label Sep 27, 2021
Copy link

@jacksonjp jacksonjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@yukinoda yukinoda added bug Something isn't working and removed bug Something isn't working labels Sep 28, 2021
@yukinoda
Copy link
Contributor

@jacksonjp
Seems TimonVS/pr-labeler-action#25 doesn't work from forks so we can ignore the CI failing on this PR.

@yannde
Thanks for your commitment, I will merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: no files matching with yarn format
3 participants