-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Let handlers add CSS to the pages, do so for Python handler #218
Conversation
OK I read your code and it's good, there are just a few things that bother me:
Based on these two points: couldn't we "simply" copy over the CSS file of the chosen theme (if any) and the CSS file of its fallback theme (if any) to the final site, without reading them into an |
Perhaps not, but maybe? Regardless, it's a necessary implementation detail (more at the bottom).
Is it a real problem to duplicate a little CSS? Conversely, your suggestion I think has a problem.
Now we get to the implementation details.
|
Alright, not a fan of this string concatenation thing but it's a nitpick and I don't want to prevent a merge just for this (and I don't see any better way myself) 😄 |
Hmm I think documentation of per-theme templates is missing, and this CSS stuff is based on it, so I added both. |
Fixes #189