Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate the recommended CSS style in the package #189

Closed
pawamoy opened this issue Dec 6, 2020 · 3 comments · Fixed by #218
Closed

Incorporate the recommended CSS style in the package #189

pawamoy opened this issue Dec 6, 2020 · 3 comments · Fixed by #218
Labels
feature New feature or request packaging Packaging or distribution issues templates Jinja templates

Comments

@pawamoy
Copy link
Member

pawamoy commented Dec 6, 2020

Is your feature request related to a problem? Please describe.
It's a bit annoying to copy over the recommended CSS in every project. Also asked here: #159 (review)

Describe the solution you'd like
We can package the recommended stylesheets.
The question is: how to use them in the MkDocs extra_css option.

@pawamoy pawamoy added feature New feature or request packaging Packaging or distribution issues templates Jinja templates labels Dec 6, 2020
@oprypin
Copy link
Member

oprypin commented Jan 10, 2021

I think I'm gonna withdraw this request. I'm also giving users the freedom to put whatever styles they want, and it also works OK without any styles

especially after the removal of .hidden-toc in https://github.com/pawamoy/mkdocstrings/pull/209/files

@pawamoy
Copy link
Member Author

pawamoy commented Jan 12, 2021

Noted. Could still be nice to have an opt-in bundled CSS file 🙂

@oprypin
Copy link
Member

oprypin commented Jan 12, 2021

FWIW I know how a plugin could add its files into the site.

on_files: add a file with a chosen arbitrary name.
on_config: insert that file name into extra_css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request packaging Packaging or distribution issues templates Jinja templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants