Simplify navbar

[tomchristie]

Refs #3680

• Drop next/prev controls.
• Drop text from search & repo controls, except in expanded menu.

expanded menu

[pawamoy]

Looks good, although the removal of the next_prev block probably is a breaking change?

[tomchristie]

Good pointer, thanks.

I've re-included it as an empty block here and amended the docs marginally. ☺️

[HumbleDeer]

The removal of the "Edit on GitHub" text might obscure the purpose of the GitHub icon in the navbar.

If this simplification is still desirable, I suggest amending this by adding an "Edit on GitHub" link at the bottom of a page instead, as is custom with a fair few other static site generator packages and other documentation generators alike.

[tomchristie]

Good catch. Tho we should switch this up completely and just have a repo_url control here, rather than page.edit_url.

If we want to keep an "Edit this page" in the default theme, then that control should be in the page area not the nav bar area.

[tomchristie]

Suggested change

	<a href="{{ page.edit_url }}" class="nav-link">
	<a href="{{ config.repo_url }}" class="nav-link">

[tomchristie]

Suggested change

	<i class="fa-brands fa-gitlab"></i><span class="d-lg-none ms-2">{% trans repo_name=config.repo_name %}Edit on {{ repo_name }}{% endtrans %}</span>
	<i class="fa-brands fa-gitlab"></i><span class="d-lg-none ms-2">{{ config.repo_name }}</span>

[tomchristie]

Suggested change

	<i class="fa-brands fa-bitbucket"></i><span class="d-lg-none ms-2">{% trans repo_name=config.repo_name %}Edit on {{ repo_name }}{% endtrans %}</span>
	<i class="fa-brands fa-bitbucket"></i><span class="d-lg-none ms-2">{{ config.repo_name }}</span>

[tomchristie]

Suggested change

	<i class="fa-brands fa-github"></i><span class="d-lg-none ms-2">{% trans repo_name=config.repo_name %}Edit on {{ repo_name }}{% endtrans %}</span>
	<i class="fa-brands fa-github"></i><span class="d-lg-none ms-2">{{ config.repo_name }}</span>

[tomchristie]

Suggested change

	{%- elif config.repo_name -%}
	{% trans repo_name=config.repo_name%}Edit on {{ repo_name }}{% endtrans %}
	{%- elif config.repo_name -%}
	{{ config.repo_name }}

[HumbleDeer]

Good catch. Tho we should switch this up completely and just have a repo_url control here, rather than page.edit_url.

If we want to keep an "Edit this page" in the default theme, then that control should be in the page area not the nav bar area.

Other docs packages often have edit buttons in the page area (indeed), and have it optional or to be enabled manually. I think that's a solid option, and agree it should be a page area element.

In that sense (and I don't mean this snarkily), a navigation bar is for navigation. Anything not navigation or locating of pages like a navigation is possibly better off in the footer or page content.

[dagnelies]

• 👍 Drop next/prev controls.
• 👍 Move "edit on Github" from the navbar to the page
• 😢 Drop text from search controls

I think these are good choice, as it would make the navbar lighter ...except for the "search". Searching is so crucial that it deserves to be clearly visible IMHO, including the "Search" label, not only the small icon.

The prev/next/edit indeed better belong to the page than the navbar.