Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop changefreq from sitemap.xml. #3629

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Drop changefreq from sitemap.xml. #3629

merged 1 commit into from
Apr 22, 2024

Conversation

tomchristie
Copy link
Member

Closes #3516.

In brief...

I've noticed that in the sitemap.xml template file [...], the tag is hard-coded to "daily"

I'd vouch for removing changefreq altogether. It's optional anyway, and I doubt that any of the big relevant search engines will use it when deciding when to re-index your site

Seems like a reasonable tweak to me.

Should this pull request also update the release notes or are we waiting until we push a release before we collate those?

Closes #3516.

(Should this pull request also update the [release notes](https://github.com/mkdocs/mkdocs/blob/master/docs/about/release-notes.md) or are we waiting until we push a release before we collate those?)
@oprypin
Copy link
Contributor

oprypin commented Apr 10, 2024

I write release notes at the end

@tomchristie tomchristie requested a review from a team April 22, 2024 14:58
Copy link
Sponsor Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong expertise or opinion here, take my approval with a grain of salt. I'd love to see other reviews from sitemap-experienced peers 🙂

@tomchristie
Copy link
Member Author

I'd love to see other reviews from sitemap-experienced peers 🙂

I'm going to act unilaterally on this in the absence of dissent. ⚡️
If you're a sitemap leet coder yell at me ask me politely to reconsider with a brief and clear rational. Or whatever.

@tomchristie tomchristie reopened this Apr 22, 2024
@tomchristie tomchristie merged commit fcb4f64 into master Apr 22, 2024
34 checks passed
@tomchristie tomchristie deleted the drop-changefreq branch April 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Configurable 'changefreq' Value in Sitemap Template
3 participants