Adding search input field labels using aria-label #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We actually sync the theme from its readthedocs upstream so maybe this should be added there first hand? |
|
Ya I submitted a fix upstream as well readthedocs/sphinx_rtd_theme#1380 |
|
FYI, the upstream patch has been merged. Should this wait for a new release of sphinx_rtd_theme? |
|
I will not require waiting, it could just be merged, because I know it will match up with upstream eventually. |
ultrabug
approved these changes
Nov 22, 2022
oprypin
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3045