Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent XSS searching in builtin themes #2791

Merged
merged 3 commits into from Mar 26, 2022
Merged

Prevent XSS searching in builtin themes #2791

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5c73ff
Prevent XSS searching in builtin themes
mondeja Mar 5, 2022
520e2a2
Also need to escape title
oprypin Mar 25, 2022
b034703
Rename method
oprypin Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion mkdocs/contrib/search/templates/search/main.js
View file
Open in desktop
Expand Up @@ -21,8 +21,15 @@ function joinUrl (base, path) {
return base + "/" + path;
}

function escapeHtml (value) {
return value.replace(/&/g, '&')
.replace(/"/g, '"')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;');
}

function formatResult (location, title, summary) {
return '<article><h3><a href="' + joinUrl(base_url, location) + '">'+ title + '</a></h3><p>' + summary +'</p></article>';
return '<article><h3><a href="' + joinUrl(base_url, location) + '">'+ escapeHtml(title) + '</a></h3><p>' + escapeHtml(summary) +'</p></article>';
}

function displayResults (results) {
Expand Down